Wait for specific MethodExitEvent in MethodReturnValuesTests#897
Merged
trancexpress merged 2 commits intoeclipse-jdt:masterfrom Mar 8, 2026
Merged
Wait for specific MethodExitEvent in MethodReturnValuesTests#897trancexpress merged 2 commits intoeclipse-jdt:masterfrom
trancexpress merged 2 commits intoeclipse-jdt:masterfrom
Conversation
trancexpress
commented
Mar 5, 2026
org.eclipse.jdt.debug.jdi.tests/tests/org/eclipse/debug/jdi/tests/EventWaiter.java
Show resolved
Hide resolved
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Author
|
@iloveeclipse how do I get access to Copilot reviews? I can't select Copilot on the reviewer list. I did opt in for Copilot enterprise from Eclipse. |
MethodReturnValuesTests can receive multiple MethodExitEvent events, before calling EventWaiter.waitEvent(). As a result, the test can potentially make its checks on the wrong event, e.g. for: MainClass.triggerEvent() This change ensures only the MethodExitEvent for the correct method is accepted by EventWaiter. Fixes: eclipse-jdt#528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MethodReturnValuesTestscan receive multipleMethodExitEventevents, before callingEventWaiter.waitEvent(). As a result, the test can potentially make its checks on the wrong event, e.g. for:MainClass.triggerEvent()This change ensures only the
MethodExitEventfor the correct method is accepted byEventWaiter.Fixes: #528